Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the 5.3 PHP support #884

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Drop the 5.3 PHP support #884

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 5, 2018

Drop the 5.3 PHP support fix build failing on 5.3.

@stof
Copy link
Collaborator

stof commented Jun 5, 2018

That's not dropping support, as you don't tell composer about the new minimum version. that's only dropping CI for 5.3 (meaning shipping untested code to PHP 5.3 users)

@james-nesbitt
Copy link

#880 includes the dropping of 5.3 support. Not sure if this is needed.

@LukeTowers
Copy link

This has been implemented in the 2.0 branch of assetic-php/assetic. Until we tag 2.0, you can pull it in by using "assetic/framework": "dev-2.0/dev" in your composer.json files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants