-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript use absolute path #796
Open
artem-frolov
wants to merge
11
commits into
kriswallsmith:master
Choose a base branch
from
artem-frolov:typescript_use_absolute_path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Typescript use absolute path #796
artem-frolov
wants to merge
11
commits into
kriswallsmith:master
from
artem-frolov:typescript_use_absolute_path
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows NODE_PATH use ';' instead of ':' for separating paths in the NODE_PATH
…real-path # Conflicts: # src/Assetic/Filter/Sass/SassFilter.php # src/Assetic/Filter/TypeScriptFilter.php
@artem-frolov thanks for your work. It looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript uses
<reference path="" />
to resolve dependencies on another files. This can cause problems with assetic, because assets are took out of their original place and they are put in a temporary directory.This pull request is based on #659 which has no new activity for more than one year.
This change allows a new setting to use absolute path instead of relative one. When asset is loaded, it's checked for
<reference path="">
and all paths are replaced with absolute paths.is translated to