Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 719: fixed numeric pattern #720

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

Eloar
Copy link
Contributor

@Eloar Eloar commented Feb 26, 2024

fix for #719, simple escape for invalid character.

@rudiedirkx
Copy link
Collaborator

Good point. To be sure, add another \ to escape the \ itself. PHP doesn't need that, but it is more readable.

@Eloar
Copy link
Contributor Author

Eloar commented Feb 28, 2024

\ escaped. I don't necessarily see it as an improvement in readability, but won't argue against that change.

@rudiedirkx
Copy link
Collaborator

In json it's a mandatory escape, in regex too (if you want to match a literal \), only in PHP it's not. I like to keep them similar. Anyway, good catch, thanks 👍

@rudiedirkx rudiedirkx merged commit 916b83d into kristijanhusak:master Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants