Update the template #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
commented
Aug 4, 2024
|
|
||
| ```sh | ||
| $ npx wrangler@latest d1 migrations apply cdph-starter |
There was a problem hiding this comment.
Removing latest since npx will use the version listed in the package.json anyways.
infomiho
commented
Aug 4, 2024
|
|
||
| ```sh | ||
| $ npx wrangler@latest d1 create starter # or name it something of your choice | ||
| $ cp wrangler.toml.example wrangler.toml |
There was a problem hiding this comment.
I've added this missing step, setting up the wrangler.toml.
infomiho
commented
Aug 4, 2024
|
|
||
| pages_build_output_dir = "./dist" | ||
|
|
||
| compatibility_flags = ["nodejs_compat"] |
There was a problem hiding this comment.
The worker wouldn't build for me without this flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've just used the template to deploy an app and I've had to do a couple of changes to make it work for me.
I've updated the README and the
wrangler.toml.examplefile to match my experience.I've also updated the
package.jsonto match.I've removed the
migrationsdir file from.gitignorebecause it makes sense to include migration files by default so the project can be worked on by multiple people.