-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud func and misc cleanup #26
Conversation
✅ Deploy Preview for gene-plexus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I forgot to open this PR yesterday. I wanted to open it today so I didn't forget and to get it off my mind, but I'd recommend waiting until Monday to review. @ChristopherMancuso You can run Faisal's |
I was able to look at this with It is nice to have pulled the info not he function input and outputs out into a readme. For that though, there is only a |
I mistakenly had that in the ml folder, see the last commit where I move it up to the folder above it. Please also make sure the notes I wrote are correct. There are probably some gaps that could be filled, like a top level comment above |
I just checked over that readme file and committed some updates. Also, I did try training in one species and testing in another and that didn't work. Probably not for this PR to worry about, right? |
How do you mean? Did you do this through the API directly? The frontend keeps them the same species for now, as we discussed. |
I did it on the front end in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it all looks good to me for this PR.
I added one more commit, please check it. I included the inputs for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
On a side note, I'm happy to see you found and updated the entrypoint.sh
script to use the new entrypoint for ml
.
Note: the deploy preview here won't work since it will be hitting the live cloud functions which are not updated with the changes in this PR yet. If you want to test just the frontend on the Netlify preview, put
?mock=true
at the end of the url and it will use fake data instead of a real api.