Improve API of SpecOrderer.orderFeatures

Use Collection<FeatureInfo> method parameter instead of Collection<SpecInfo>, streamlining method implementations by factoring out looping over SpecInfos into SpecOrderer.process. Relates to spockframework#1443.
kriegaex · Apr 16, 2023 · 81a9307 · 81a9307
1 parent 7cf5419
commit 81a9307
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/...va/org/spockframework/runtime/extension/builtin/orderer/AnnotatationBasedSpecOrderer.java b/...va/org/spockframework/runtime/extension/builtin/orderer/AnnotatationBasedSpecOrderer.java
@@ -5,7 +5,6 @@
 import spock.lang.Order;
 
 import java.util.Collection;
-import java.util.concurrent.atomic.AtomicInteger;
 
 public class AnnotatationBasedSpecOrderer extends SpecOrderer {
   public AnnotatationBasedSpecOrderer() {
@@ -21,12 +20,10 @@ protected void orderSpecs(Collection<SpecInfo> specs) {
   }
 
   @Override
-  protected void orderFeatures(Collection<SpecInfo> specs) {
-    for (SpecInfo spec : specs) {
-      for (FeatureInfo feature : spec.getAllFeatures()) {
-        Order orderAnnotation = feature.getFeatureMethod().getAnnotation(Order.class);
-        feature.setExecutionOrder(orderAnnotation == null ? 0 : orderAnnotation.value());
-      }
+  protected void orderFeatures(Collection<FeatureInfo> features) {
+    for (FeatureInfo feature : features) {
+      Order orderAnnotation = feature.getFeatureMethod().getAnnotation(Order.class);
+      feature.setExecutionOrder(orderAnnotation == null ? 0 : orderAnnotation.value());
     }
   }
 }
diff --git a/...rc/main/java/org/spockframework/runtime/extension/builtin/orderer/DefaultSpecOrderer.java b/...rc/main/java/org/spockframework/runtime/extension/builtin/orderer/DefaultSpecOrderer.java
@@ -1,5 +1,6 @@
 package org.spockframework.runtime.extension.builtin.orderer;
 
+import org.spockframework.runtime.model.FeatureInfo;
 import org.spockframework.runtime.model.SpecInfo;
 
 import java.util.Collection;
@@ -13,5 +14,5 @@ public DefaultSpecOrderer() {
   protected void orderSpecs(Collection<SpecInfo> specs) { }
 
   @Override
-  protected void orderFeatures(Collection<SpecInfo> specs) { }
+  protected void orderFeatures(Collection<FeatureInfo> features) { }
 }
diff --git a/...src/main/java/org/spockframework/runtime/extension/builtin/orderer/RandomSpecOrderer.java b/...src/main/java/org/spockframework/runtime/extension/builtin/orderer/RandomSpecOrderer.java
@@ -5,7 +5,6 @@
 
 import java.util.Collection;
 import java.util.Random;
-import java.util.concurrent.atomic.AtomicInteger;
 
 public class RandomSpecOrderer extends SpecOrderer {
   private final Random random;
@@ -30,10 +29,8 @@ protected void orderSpecs(Collection<SpecInfo> specs) {
   }
 
   @Override
-  protected void orderFeatures(Collection<SpecInfo> specs) {
-    for (SpecInfo spec : specs) {
-      for (FeatureInfo feature : spec.getAllFeatures())
-        feature.setExecutionOrder(random.nextInt());
-    }
+  protected void orderFeatures(Collection<FeatureInfo> features) {
+    for (FeatureInfo feature : features)
+      feature.setExecutionOrder(random.nextInt());
   }
 }
diff --git a/...-core/src/main/java/org/spockframework/runtime/extension/builtin/orderer/SpecOrderer.java b/...-core/src/main/java/org/spockframework/runtime/extension/builtin/orderer/SpecOrderer.java
@@ -18,12 +18,15 @@ public SpecOrderer(boolean orderSpecs, boolean orderFeatures) {
   public void process(Collection<SpecInfo> specs) {
     if (orderSpecs)
       orderSpecs(specs);
-    if (orderFeatures)
-      orderFeatures(specs);
+    if (!orderFeatures)
+      return;
+    for (SpecInfo spec : specs)
+      orderFeatures(spec.getAllFeatures());
   }
 
   protected abstract void orderSpecs(Collection<SpecInfo> specs);
-  protected abstract void orderFeatures(Collection<SpecInfo> specs);
+
+  protected abstract void orderFeatures(Collection<FeatureInfo> features);
 
   public boolean isOrderSpecs() {
     return orderSpecs;