Skip to content

Commit

Permalink
Merge pull request #66 from JonathanLorimer/add-state-argument-to-delete
Browse files Browse the repository at this point in the history
Add state argument to delete
  • Loading branch information
krdlab authored Jul 29, 2024
2 parents 93a64b9 + 71c8f31 commit 5f88f84
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion examples/scotty/Main.hs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ run' = do
{ sessionStoreGenerate = genBytes cprg
, sessionStoreSave = saveState ssm sid
, sessionStoreGet = getStateBy ssm sid
, sessionStoreDelete = deleteState ssm sid
, sessionStoreDelete = const $ deleteState ssm sid
}

blaze = html . renderHtml
Expand Down
2 changes: 1 addition & 1 deletion src/Web/OIDC/Client/CodeFlow.hs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ getValidTokens store oidc mgr stateFromIdP code = do
savedNonce <- sessionStoreGet store stateFromIdP
when (isNothing savedNonce) $ throwM UnknownState
result <- liftIO $ requestTokens oidc savedNonce code mgr
sessionStoreDelete store
sessionStoreDelete store stateFromIdP
return result

-- | Make URL for Authorization Request.
Expand Down
2 changes: 1 addition & 1 deletion src/Web/OIDC/Client/IdTokenFlow.hs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ getValidIdTokenClaims store oidc stateFromIdP getIdToken = do
msavedNonce <- sessionStoreGet store stateFromIdP
savedNonce <- maybe (liftIO $ throwIO UnknownState) pure msavedNonce
jwt <- Jwt.Jwt <$> getIdToken
sessionStoreDelete store
sessionStoreDelete store stateFromIdP
idToken <- liftIO $ validateIdToken oidc jwt
nonce' <- maybe (liftIO $ throwIO MissingNonceInResponse) pure (nonce idToken)
when (nonce' /= savedNonce) $ liftIO $ throwIO MismatchedNonces
Expand Down
2 changes: 1 addition & 1 deletion src/Web/OIDC/Client/Types.hs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ data SessionStore m = SessionStore
, sessionStoreSave :: State -> Nonce -> m ()
, sessionStoreGet :: State -> m (Maybe Nonce)
-- ^ Returns 'Nothing' if 'State' is unknown
, sessionStoreDelete :: m ()
, sessionStoreDelete :: State -> m ()
-- ^ Should delete at least nonce
}

0 comments on commit 5f88f84

Please sign in to comment.