Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: used mixed for JSON-able types #78

Merged
merged 1 commit into from
Aug 18, 2023
Merged

feat: used mixed for JSON-able types #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ export function Logger({
print(
LOG_LEVEL.DEBUG,
`metric.${metricPayload.metricNamespace}`,
// $FlowIssue difference between Payload and metric dimensions
metricPayload.dimensions || {}
);

Expand Down
4 changes: 2 additions & 2 deletions src/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* @flow */

export type Payload = { [string]: string | boolean | null | void };
export type Payload = { [string]: mixed };

export type MetricPayload = {|
metricNamespace: string, // the name of the metric that's used for charting / finding in signalFx
Expand All @@ -12,5 +12,5 @@ export type MetricPayload = {|
* - https://engineering.paypalcorp.com/confluence/pages/viewpage.action?pageId=981633893
* - https://engineering.paypalcorp.com/confluence/display/Checkout/Checkout+Observability+Overview
*/
dimensions?: { [string]: string },
dimensions?: { [string]: mixed },
|};
Loading