-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disableBrowserLogging option #28 #37
base: main
Are you sure you want to change the base?
Conversation
@mnicpt @bluepnume can you take a look at ^^? |
Yes. @musps I think disableBrowserLogging would be a better name since it's already enabled. Can you update this? |
@musps Can you revert the /dist changes. This will happen automatically when we publish. |
@mnicpt Both are done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @musps, for taking this on! Looks great! 🎉
any chance to release this enhancement soon? |
Thank you! looking forward for this PR to be merged as well! One note, though, if it's not too much trouble I think it makes for a better API to have a browser log level instead of a flag. For our needs, for instance, it would be preferable to have only errors emitted to console and everything allowed by You may even want to add a level above error (SUPPRESS? IGNORE?) which will cover the 'complete disable' use case, instead of another argument. If required (provided you approve of this direction) I think I can make this change, building off @musps great work |
Hello,
From the issue #28, someone asked if it was possible to have an option to disable logs appearing in the browser console.
Option
This option will disable the function print to be executed internally and will not print the logs in the browser console.
Usage