Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #10

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add CONTRIBUTING.md #10

merged 1 commit into from
Aug 13, 2024

Conversation

marcelofern
Copy link
Contributor

Previously, the sections about installing, testing, and updating were under the README.md file.

This commit changes that by adding a dedicated CONTRIBUTING.md file responsible for describing all the necessary information to kick start new contributors to django-pg-migration-tools.

@marcelofern marcelofern marked this pull request as ready for review August 12, 2024 23:48
CONTRIBUTING.md Outdated
python --version
```

Ensure that you have the `uv` package installed as a **system** dependency.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it matter where the uv comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. It actually does not matter where uv comes from. In fact, I don't even have uv installed as a system package and I've been obviously running this repo just fine.

✂️ removed here: 6baa929

Upgrade a single dependency with:

```sh
pip-compile -P $PACKAGE==$VERSION pyproject.toml --resolver=backtracking --extra=dev --output-file=requirements/development.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit weird this isn't a make command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I will take note of that and open a separated issue for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #11

Previously, the sections about installing, testing, and updating were
under the README.md file.

This commit changes that by adding a dedicated CONTRIBUTING.md file
responsible for describing all the necessary information to kick start
new contributors to `django-pg-migration-tools`.
@marcelofern marcelofern force-pushed the add-contributing-file branch from 6baa929 to 977ca75 Compare August 13, 2024 00:25
@marcelofern marcelofern merged commit cce266c into main Aug 13, 2024
6 checks passed
@marcelofern marcelofern deleted the add-contributing-file branch August 13, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants