Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing release requirement #41

Merged
merged 1 commit into from
May 13, 2024
Merged

Add missing release requirement #41

merged 1 commit into from
May 13, 2024

Conversation

meshy
Copy link
Contributor

@meshy meshy commented May 13, 2024

Before this change, we saw an error in CI when we tried to make a release:

ModuleNotFoundError: No module named 'packaging'

Ref: https://github.com/kraken-tech/django-integrity/actions/runs/9062077439/job/24895172273

Before this change, we saw an error in CI when we tried to make a
release:

    ModuleNotFoundError: No module named 'packaging'
@meshy meshy requested a review from a team May 13, 2024 11:33
Copy link
Contributor

@samueljsb samueljsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not blocking) the constraints still smell funny to me

@meshy
Copy link
Contributor Author

meshy commented May 13, 2024

the constraints still smell funny to me

Yeah -- it's possible I've missed something there.

@meshy meshy merged commit defaad9 into main May 13, 2024
9 checks passed
@meshy meshy deleted the fix-release-requirements branch May 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants