Ignore deliberate type errors

These tests deliberately pass the wrong type so that the error handling can be tested, so there's no need to track these errors in the type ratchet.
kraken-tech · May 9, 2024 · 50482ae · 50482ae
1 parent e506947
commit 50482ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/mypy-ratchet.json b/mypy-ratchet.json
@@ -1,12 +1,9 @@
 {
   "tests/django_integrity/test_conversion.py": {
-    "Argument \"model\" to \"Unique\" has incompatible type \"Unique\"; expected \"type[Model]\"  [arg-type]": 1,
     "Argument 1 to \"refine_integrity_error\" has incompatible type \"dict[ForeignKey, type[SimpleError]]\"; expected \"Mapping[_Rule, Exception]\"  [arg-type]": 3,
     "Argument 1 to \"refine_integrity_error\" has incompatible type \"dict[Named, type[SimpleError]]\"; expected \"Mapping[_Rule, Exception]\"  [arg-type]": 2,
     "Argument 1 to \"refine_integrity_error\" has incompatible type \"dict[NotNull, type[SimpleError]]\"; expected \"Mapping[_Rule, Exception]\"  [arg-type]": 3,
     "Argument 1 to \"refine_integrity_error\" has incompatible type \"dict[PrimaryKey, type[SimpleError]]\"; expected \"Mapping[_Rule, Exception]\"  [arg-type]": 2,
-    "Argument 1 to \"refine_integrity_error\" has incompatible type \"dict[Unique, type[SimpleError]]\"; expected \"Mapping[_Rule, Exception]\"  [arg-type]": 3,
-    "Incompatible type for \"unique_field\" of \"AlternativeUniqueModel\" (got \"None\", expected \"float | int | str | Combinable\")  [misc]": 1,
-    "Incompatible type for \"unique_field\" of \"UniqueModel\" (got \"None\", expected \"float | int | str | Combinable\")  [misc]": 2
+    "Argument 1 to \"refine_integrity_error\" has incompatible type \"dict[Unique, type[SimpleError]]\"; expected \"Mapping[_Rule, Exception]\"  [arg-type]": 3
   }
 }
diff --git a/tests/django_integrity/test_conversion.py b/tests/django_integrity/test_conversion.py
@@ -174,7 +174,8 @@ def test_error_refined(self) -> None:
         # The original error should be transformed into our expected error.
         with pytest.raises(SimpleError):
             with conversion.refine_integrity_error(rules):
-                test_models.UniqueModel.objects.create(unique_field=None)
+                # We ignore the type error because it's picking up on the error we're testing.
+                test_models.UniqueModel.objects.create(unique_field=None)  # type: ignore[misc]
 
     def test_model_mismatch(self) -> None:
         # Same field, but different model.
@@ -186,7 +187,8 @@ def test_model_mismatch(self) -> None:
 
         with pytest.raises(django_db.IntegrityError):
             with conversion.refine_integrity_error(rules):
-                test_models.UniqueModel.objects.create(unique_field=None)
+                # We ignore the type error because it's picking up on the error we're testing.
+                test_models.UniqueModel.objects.create(unique_field=None)  # type: ignore[misc]
 
     def test_field_mismatch(self) -> None:
         # Same model, but different field.
@@ -200,7 +202,8 @@ def test_field_mismatch(self) -> None:
         with pytest.raises(django_db.IntegrityError):
             with conversion.refine_integrity_error(rules):
                 test_models.AlternativeUniqueModel.objects.create(
-                    unique_field=None,
+                    # We ignore the type error because it's picking up on the error we're testing.
+                    unique_field=None,  # type: ignore[misc]
                     unique_field_2=42,
                 )