Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang to 1.22.4 #4164

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update golang to 1.22.4 #4164

merged 2 commits into from
Jun 28, 2024

Conversation

louisjimenez
Copy link
Contributor

No description provided.

@droot
Copy link
Contributor

droot commented Jun 27, 2024

I think there is an test failure that is unrelated to this PR. The fix for that test probably requires filtering out the DEPRECATION NOTICE message from the docker.

FAIL: TestContainerFn (0.64s)
    --- FAIL: TestContainerFn/simple_busybox (0.38s)
        container_test.go:67: 
            	Error Trace:	/home/runner/work/kpt/kpt/go/src/github.com/GoogleContainerTools/kpt/internal/fnruntime/container_test.go:67
            	Error:      	Received unexpected error:
            	            	  Stderr:
            	            	    "docker: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of gcr.io/google-containers/busybox:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at [https://docs.docker.com/go/deprecated-image-specs/.](https://docs.docker.com/go/deprecated-image-specs/)"
            	            	    "See 'docker run --help'."
            	            	  Exit Code: 125
            	Test:       	TestContainerFn/simple_busybox
FAIL

@droot
Copy link
Contributor

droot commented Jun 27, 2024

@louisjimenez can we bump the Go version to 1.22.4 ?

Signed-off-by: Louis Jimenez <[email protected]>
@louisjimenez louisjimenez changed the title Update golang to 1.21.11 Update golang to 1.22.4 Jun 27, 2024
@louisjimenez
Copy link
Contributor Author

@louisjimenez can we bump the Go version to 1.22.4 ?

Done

@louisjimenez
Copy link
Contributor Author

Can we pull in the fix here #4165?

@droot
Copy link
Contributor

droot commented Jun 27, 2024

Can we pull in the fix here #4165?

Let's copy that change here and get it in with this. Makes sense.

@louisjimenez
Copy link
Contributor Author

Can we pull in the fix here #4165?

Let's copy that change here and get it in with this. Makes sense.

Cherry-picked the fix.

@droot
Copy link
Contributor

droot commented Jun 28, 2024

/lgtm
/approve

@droot droot merged commit 1d13188 into kptdev:main Jun 28, 2024
10 checks passed
@louisjimenez louisjimenez deleted the UpdateToGo12111 branch June 28, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants