feat(transactions): Transaction added to garantee only once paradigm #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 96.00% 95.98% -0.03%
==========================================
Files 24 25 +1
Lines 977 1095 +118
==========================================
+ Hits 938 1051 +113
- Misses 39 44 +5 ☔ View full report in Codecov by Sentry. |
marcosschroh
force-pushed
the
feat/add-transantions
branch
5 times, most recently
from
4259bf1 to
2860cd3
Compare
marcosschroh
force-pushed
the
feat/add-transantions
branch
2 times, most recently
from
b2c3546 to
abaea8b
Compare
woile
reviewed
Mar 3, 2025
|
|
||
| ```python title="Transaction inside a stream" | ||
| @stream_engine.stream("a-topic", group_id="my-group") | ||
| async def stream_a(cr: ConsumerRecord, transactional: Transactional): |
There was a problem hiding this comment.
Wouldn't be better to call the type Transaction? transactional is an adjective, is a property of something
There was a problem hiding this comment.
Yes, the name change is in the list. The PR is still a draft
marcosschroh
force-pushed
the
feat/add-transantions
branch
8 times, most recently
from
57982a3 to
d9724bc
Compare
marcosschroh
force-pushed
the
feat/add-transantions
branch
from
d9724bc to
6c40c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.