Merge pull request #366 from kpi-ua/fix-componentDidMount

src/App.js

@@ -41,8 +41,10 @@ class App extends Component {
     };
   }
 
-  async componentDidMount() {
-    this.setState({ user: await campus.getCurrentUser(true) });
+  componentDidMount() {
+    campus.getCurrentUser(true).then(user => {
+      this.setState({ user });
+    });
   }
 
   render() {

src/components/Bb/BbList.js

@@ -17,19 +17,7 @@ class BbList extends React.Component {
     };
   }
 
-  async componentDidMount() {
-    const response = await campus.getBulletinBoardForCurrentUser(
-      1,
-      this.state.pageSize,
-    );
-
-    if (!!response) {
-      this.setState({
-        items: response.data,
-        activePage: 1,
-        paging: response.paging,
-      });
-    }
+  componentDidMount() {
   }
 
   dateToString = (date) =>

src/components/Home.js

@@ -10,21 +10,26 @@ class Home extends React.Component {
     user: null,
   };
 
-  async componentDidMount() {
+  componentDidMount() {
+    this.initializeUser();
+  }
+
+  initializeUser = async () => {
     const user = await campus.getCurrentUser();
 
     if (!user) {
       this.props.history.push('/login');
       return;
-    } else {
-      if (!user.modules) {
-        await campus.logout();
-        window.location.href = 'https://ecampus.kpi.ua/';
-      }
+    }
+
+    if (!user.modules) {
+      await campus.logout();
+      window.location.href = 'https://ecampus.kpi.ua/';
+      return;
     }
 
     this.setState({ user });
-  }
+  };
 
   redirectToOldUI = async (e) => {
     e.preventDefault();

src/components/KPIID.js

@@ -12,7 +12,11 @@ class KpiId extends React.Component {
     super(props);
   }
 
-  componentDidMount = async () => {
+  componentDidMount() {
+    this.handleAuthentication();
+  }
+
+  handleAuthentication = async () => {
     try {
       const params = new URLSearchParams(this.props.location.search);
       const ticketId = params.get('ticketId');
@@ -24,7 +28,7 @@ class KpiId extends React.Component {
 
       const currentUser = await campus.exchangeKpiIdTicket(ticketId);
 
-      if (!!currentUser) {
+      if (currentUser) {
         this.setState({ redirect: '/home' });
       } else {
         this.setState({ error: 'Failed to authenticate using KPI ID' });

src/components/Login.js

@@ -9,11 +9,15 @@ class Login extends React.Component {
     redirect: null
   };
 
-  componentDidMount = async () => {
+  componentDidMount() {
+    this.authenticateUser();
+  }
+
+  authenticateUser = async () => {
     try {
       const currentUser = await campus.getCurrentUser(true);
 
-      if (!!currentUser) {
+      if (currentUser) {
         this.setState({ redirect: '/home' });
       } else {
         this.setState({ error: 'Failed to authenticate using KPI ID' });

src/components/Settings.js

@@ -9,7 +9,11 @@ class Settings extends React.Component {
     user: {},
   };
 
-  async componentDidMount() {
+  componentDidMount() {
+    this.loadUser();
+  }
+
+  loadUser = async () => {
     const user = await campus.getCurrentUser(true);
 
     if (!user) {
@@ -18,7 +22,7 @@ class Settings extends React.Component {
     }
 
     this.setState({ user });
-  }
+  };
 
   render() {
     const { user } = this.state;

src/components/SettingsEditor.js

@@ -21,23 +21,29 @@ class SettingsEditor extends React.Component {
     redirect: null
   };
 
-  async componentDidMount() {
+  componentDidMount() {
+    this.loadUser();
+  }
+
+  loadUser = async () => {
     const user = await campus.getCurrentUser();
 
     if (!user) {
       this.props.history.push('/login');
       return;
     }
 
-    this.setState({ user });
-    this.setState({ email: user.email });
-    this.setState({ credo: user.credo });
-    this.setState({ scientificInterests: user.scientificInterests });
-    this.setState({ fullName: user.fullName });
-    this.setState({ currentPassword: '' });
-    this.setState({ password: '' });
-    this.setState({ passwordConfirmation: '' });
-  }
+    this.setState({
+      user,
+      email: user.email,
+      credo: user.credo,
+      scientificInterests: user.scientificInterests,
+      fullName: user.fullName,
+      currentPassword: '',
+      password: '',
+      passwordConfirmation: '',
+    });
+  };
 
   /**
    * Validate password

src/components/UserProfileImage.js

@@ -7,7 +7,7 @@ class UserProfileImage extends React.Component {
     rnd: 0,
   };
 
-  async componentDidMount() {
+  componentDidMount() {
     this.setState({ rnd: getRandomNumber() });
   }