feat: add configurable HTML-ID prefix for SVG codes #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option for callers to provide an HTML-ID prefix for SVG QR-codes, in order to make them unique and enable using this library for multiple QR-codes on a single page. Further it adds a .node-version file which can be used by nodenv or just manual node version selection, to specify a node version that is able to install, build and test this code base without adding any changes. Closes kozakdenys#210.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option for callers to provide an HTML-ID prefix for SVG QR-codes, in order to make them unique and enable using this library for multiple QR-codes on a single page.
Further it adds a .node-version file which can be used by nodenv or just manual node version selection, to specify a node version that is able to install, build and test this code base without adding any changes.
Closes #210.