Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLint #414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add HLint #414

wants to merge 1 commit into from

Conversation

blackheaven
Copy link

@blackheaven blackheaven commented Oct 1, 2022

I'm sorry for the unsolicited PR but I planned to do a hlint contribution on another repository and another contribution for this one and I mixed my folders :s

I push it so it could be useful eventually, and I'm going to make my contribution on this one as I planned to do.

Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a nice contribution!
Only small thing to fix at the moment 👌🏼

README.md Outdated
@@ -230,6 +230,14 @@ make it unique:
Haskell types and `htoml*` libraries use typeclasses-based approach
via `aeson` library.

## Development

`iris` uses `hlint`, you can run it through:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this name is from other PR 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused :x

I've pushed a fix.

@vrom911 vrom911 added CI CI (Travis, Windows), build problems with different build tools and different versions refactoring Hacktoberfest https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept contributions during Hacktoberfest labels Oct 2, 2022
@@ -0,0 +1,76 @@
# HLint configuration file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the default file or some additional configurations were added here?
I think it is okay if we use the default one without adding the config file at all 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the default one

@blackheaven
Copy link
Author

@vrom911 is there anything I can do/improve to get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI (Travis, Windows), build problems with different build tools and different versions Hacktoberfest https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept contributions during Hacktoberfest refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants