Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly find wrapped lines in history buffer #8322

Merged

Conversation

rivenirvana
Copy link
Contributor

@rivenirvana rivenirvana commented Feb 12, 2025

Off-by-one error in f412ec6. Kitty is failing to find the previous prompt when trying to page the last command output (via ctrl+shift+g) when the executed command is long enough that it wraps and the output is long enough to put the prompt in the history buffer. The result is either:

  • Paged cmd output is empty; or
  • Paged output contains cmd outputs from up to the first prompt that has a non-wrapping command; or
  • The last wrapped line of the command is included in the paged output when paging via mouse (ctrl+shift+rclick)

@kovidgoyal kovidgoyal merged commit a31aa1f into kovidgoyal:master Feb 12, 2025
10 checks passed
@rivenirvana rivenirvana deleted the fix-historybuf-cmd-output-paging branch February 12, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants