fix: return consistent results from readers #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #57
The test case is the same as from the issue.
That doesn't cover "consistency" fully but at least its a regression for this case.
More tests should be added to ensure that the same input produces a similar result (Ok/Err) across the different readers. I could write a macro for this if desired.
The fix is also a bit dubious. I'm not entirely sure what the
output.len() < self.buffer.capacity()line is for. I removed it because I noticed that the issue was caused by the capacity set on the circular buffer. Expecting a vec with length of >= 8192 would fail but anything shorter would succeed.