Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #53: CPU temperature goes to off state #54

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

roachsinai
Copy link

This pull request to solve #52 .

And also solve #16 and #53 these two are same problem, which I think the reason is #52 .

@dvalter
Copy link

dvalter commented Jan 25, 2019

This patch has fixed #16 / #52 / #53 in my case.
Another solution might be removing the following lines of code.

diff --git a/package/contents/ui/main.qml b/package/contents/ui/main.qml
index 67e3f4c..6081d52 100644
--- a/package/contents/ui/main.qml
+++ b/package/contents/ui/main.qml
@@ -277,13 +277,8 @@ Item {
 
             dbgprint('adding source to systemmonitorDS: ' + source)
 
-            if (getSystemmonitorAvailableSources().indexOf(source) > -1) {
                 dbgprint('adding to connected')
                 addToSourcesOfDatasource(systemmonitorDS, source)
-            } else {
-                dbgprint('adding to sta')
-                systemmonitorSourcesToAdd.push(source)
-            }
 
         }

It works fine as well

@roachsinai
Copy link
Author

Yes, caues comment this line,

if (getSystemmonitorAvailableSources().indexOf(source) > -1) {

resulted in this variable systemmonitorAvailableSources never been used, so there is no error.

And I think the code which removed in your patch and variable systemmonitorAvailableSources is created to avoid source be added multiple times to systemmonitorDS. But each time systemmonitorDS was reset with every chage we did to this plasmoid at function reloadAllSources

systemmonitorDS.connectedSources.length = 0

So, I think it will also be fine you remove all things related to variable systemmonitorAvailableSources.

@bodziek666
Copy link

bodziek666 commented Jul 24, 2019

Works fine for me on VoidLinux! Thank you for your effort. I hope this will be merged soon enough :)
EDIT: works fine on ubuntu 19.04 on my second computer as well :)

@roachsinai roachsinai changed the title let var systemmonitorAvailableSources refer to an empty array. Solution #53: CPU temperature goes to off state Sep 12, 2019
@roachsinai roachsinai mentioned this pull request Sep 22, 2019
@kwhat
Copy link

kwhat commented Sep 28, 2019

This still seems a bit wonky for me... It took a few reloads to get lm sensors to show up

@roachsinai
Copy link
Author

Maybe you should use journalctl like #52 to find the error as I'm not using this plasmoid.

@ivnish
Copy link

ivnish commented Jan 19, 2022

It works. Please commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants