Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Fix default values of array-type parameters in a referenced file #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kota65535
Copy link
Owner

@kota65535 kota65535 commented Feb 3, 2024

fix: xxxxx

If a parameter is referencing an array-type schema in an external file using $ref, its default value will be rendered with unneeded square braces like [foo, bar]. This PR removes them.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kota65535 kota65535 changed the title fix invalid default values of parameters with array type [Java] Remove square braces of a default value of a parameter with array type Feb 3, 2024
@kota65535 kota65535 force-pushed the parameter-array branch 4 times, most recently from 354a477 to eeebe17 Compare February 3, 2024 03:50
@kota65535 kota65535 changed the title [Java] Remove square braces of a default value of a parameter with array type [Java] Fix default values of parameters with array type in a referenced file Feb 3, 2024
@kota65535 kota65535 changed the title [Java] Fix default values of parameters with array type in a referenced file [Java] Fix default values of array parameters in a referenced file Feb 3, 2024
@kota65535 kota65535 changed the title [Java] Fix default values of array parameters in a referenced file [Java] Fix default values of array-type parameters in a referenced file Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant