Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latexify sparse arrays #302

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Latexify sparse arrays #302

merged 5 commits into from
Aug 8, 2024

Conversation

gustaphe
Copy link
Collaborator

@gustaphe gustaphe commented Aug 7, 2024

Close #269

Sparse arrays did not work. Since that's a stdlib, I figured it was uncontroversial to using it.
This is significant because it's our first "internal recipe". There's probably several types we currently have hard-coded that could be made into recipes like this.

Also, in the future someone might do something clever about sparse matrices, like only printing significant zeroes etc. This just turns it into a normal matrix before latexifying.

@ChrisRackauckas
Copy link
Contributor

Since that's a stdlib

It's not anymore 😅 , and it is controversial because it has a GPL dependency. I am recommending all libraries make SparseArrays into an extension, so I'll also recommend that here.

@gustaphe
Copy link
Collaborator Author

gustaphe commented Aug 7, 2024

Ach, I was hoping to avoid that, but I guess it's cleaner anyway. Thanks for the heads up.

@gustaphe
Copy link
Collaborator Author

gustaphe commented Aug 7, 2024

Since that's a stdlib

It's not anymore 😅

Someone should tell the docs

@ChrisRackauckas
Copy link
Contributor

Maybe it's still there, but it's:

  1. No longer in the system image, so it's not loaded by default
  2. It's maintained in a separate repository in a different Github organization
  3. Importantly, Suitesparse is not loaded until it's loaded (which wasn't true until v1.10)
  4. You can soon (v1.12?) build system images without it in there (making a GPL free system image)

For backwards compatibility reasons I think it'll have to continue coming with the standard Julia installation, but it effectively is just a separate package that is now shipped with the standard binary and not even in the image.

@gustaphe
Copy link
Collaborator Author

gustaphe commented Aug 7, 2024

It functionally doesn't matter, I was just rationalizing my own laziness. Always interesting to learn a bit more about the nuts and bolts though.

@gustaphe gustaphe merged commit f4b1546 into korsbo:master Aug 8, 2024
9 checks passed
@gustaphe gustaphe deleted the sparse branch August 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent breakage of Latexify on sparse matrices?
2 participants