Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential bugs by switching from Formatting.jl to Format.jl #281

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

ScottPJones
Copy link
Contributor

Also eliminated the need to do @eval at run-time just for numeric formatting, which also eliminates the need for Printf as a dependency.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b869c3) 82.38% compared to head (cf8b97f) 82.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   82.38%   82.66%   +0.27%     
==========================================
  Files          21       21              
  Lines         829      819      -10     
==========================================
- Hits          683      677       -6     
+ Misses        146      142       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScottPJones
Copy link
Contributor Author

Note: the failure on nightly happens on master, and is unrelated to this PR, and the Documentation check is also unrelated to the change.

Can this be merged now? Thanks in advance!

@nhz2
Copy link

nhz2 commented Feb 27, 2024

This looks good to me.

@oscardssmith
Copy link

Can this be merged?

@ScottPJones
Copy link
Contributor Author

ScottPJones commented Mar 3, 2024

Can this be merged?

Just waiting on someone who has permission to do so!

@korsbo korsbo merged commit a7ee6f5 into korsbo:master Mar 3, 2024
8 of 10 checks passed
@ScottPJones ScottPJones deleted the spj/useformat branch March 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants