Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: expose icp algorithm to pyo3 #236

Merged
merged 1 commit into from
Feb 16, 2025
Merged

py: expose icp algorithm to pyo3 #236

merged 1 commit into from
Feb 16, 2025

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Feb 16, 2025

This pull request introduces several changes to add ICP (Iterative Closest Point) functionality to the kornia-py package, including new modules, classes, and tests. The most important changes include adding new dependencies, implementing the ICP algorithm in Rust and exposing it to Python, and creating corresponding unit tests.

New Features:

  • kornia-py/Cargo.toml: Added dependencies for kornia-icp and kornia-3d crates.
  • kornia-py/src/icp.rs: Implemented the PyICPConvergenceCriteria and PyICPResult classes and the icp_vanilla function to expose the ICP algorithm to Python.
  • kornia-py/src/pointcloud.rs: Added FromPyPointCloud trait and PyPointCloud type to facilitate point cloud data conversion between Python and Rust.

Code Integration:

  • kornia-py/src/lib.rs: Integrated the new ICP functionality by importing the necessary modules and adding the new classes and functions to the Python module. [1] [2] [3]

Testing:

  • kornia-py/tests/test_icp.py: Added unit tests for the new ICP functionality, including tests for ICPConvergenceCriteria, ICPResult, and the icp_vanilla function.

Miscellaneous:

@edgarriba edgarriba merged commit 22bd5ac into main Feb 16, 2025
12 checks passed
@edgarriba edgarriba deleted the icp-python branch February 16, 2025 16:04
@edgarriba edgarriba changed the title kornia_py: expose icp algorithm to pyo3 py: expose icp algorithm to pyo3 Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant