Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to add ICP (Iterative Closest Point) functionality to the
kornia-py
package, including new modules, classes, and tests. The most important changes include adding new dependencies, implementing the ICP algorithm in Rust and exposing it to Python, and creating corresponding unit tests.New Features:
kornia-py/Cargo.toml
: Added dependencies forkornia-icp
andkornia-3d
crates.kornia-py/src/icp.rs
: Implemented thePyICPConvergenceCriteria
andPyICPResult
classes and theicp_vanilla
function to expose the ICP algorithm to Python.kornia-py/src/pointcloud.rs
: AddedFromPyPointCloud
trait andPyPointCloud
type to facilitate point cloud data conversion between Python and Rust.Code Integration:
kornia-py/src/lib.rs
: Integrated the new ICP functionality by importing the necessary modules and adding the new classes and functions to the Python module. [1] [2] [3]Testing:
kornia-py/tests/test_icp.py
: Added unit tests for the new ICP functionality, including tests forICPConvergenceCriteria
,ICPResult
, and theicp_vanilla
function.Miscellaneous:
kornia-py/.gitignore
: Addeduv.lock
to the.gitignore
file.crates/kornia-icp/src/icp_vanilla.rs
: AddedClone
trait toICPConvergenceCriteria
struct.