Avoid exports in AppConfig when running management commands #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, migrations are being exported inside the
ready()
method of thedjango_prometheus.apps.AppConfig
. This works fine for a default threaded prometheus mode, but leads to malformed metrics when using prometheus in multiprocess mode.Consider the following typical deployment entrypoint:
This leads to problems like this:
This PR introduces a simple check to avoid exporting metrics in
manage.py
commands