-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform field to ActivityData and DiscordActivity #995
Conversation
Are these documented, if so could we use a "kordenum" |
Do you mean it should be an enum type to represent each playform? |
I found an implementation like this. But these platforms are inaccurate, so it's safer to be just a string. |
Kord enums do have an |
OK, I’ll define the enum values based on this. |
@DRSchlaubi I defined the known platforms as the Kord Enum. And I confirmed it works for a known platform or an unknown value. |
Co-authored-by: Luca Kellermann <[email protected]>
thanks! |
Summary
This PR adds
platform
property toActivity
.When users play games from consoles. The Discord Activity API returns the below response.
According to the documentation, this field is undocumented, but I confirmed this value was returned.
See also the this PR for Discord.py.