Skip to content

Commit

Permalink
Rolling back license plugin version due to Gradle 7 incompatibility
Browse files Browse the repository at this point in the history 
See hierynomus/license-gradle-plugin#193
  • Loading branch information
@aalmiray
aalmiray committed May 14, 2021
1 parent f76ccfe commit 28bac60
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/licensing-gradle-plugin/licensing-gradle-plugin.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@
*/
dependencies {
api project(':base-gradle-plugin')
api 'gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.16.1'
api 'gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.15.0'
}

3 comments on commit 28bac60

@musketyr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalmiray what was the issue with the latest plugin version? it works well for me with Gradle 7.1.1 and Kordamp 0.46.0

pluginManagement {
    repositories {
        gradlePluginPortal()
        mavenCentral()
    }
    plugins {
        id 'org.kordamp.gradle.settings'                version kordampPluginVersion
        id 'org.kordamp.gradle.groovy-project'          version kordampPluginVersion
        id 'org.kordamp.gradle.checkstyle'              version kordampPluginVersion
        id 'org.kordamp.gradle.codenarc'                version kordampPluginVersion
        id 'org.kordamp.gradle.coveralls'               version kordampPluginVersion
        id 'io.github.gradle-nexus.publish-plugin'      version nexusPluginVersion
    }
}

buildscript {
    repositories {
        gradlePluginPortal()
    }
    dependencies {
        classpath "gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.16.1"
    }
}

@aalmiray
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.16.1 of the license-gradle-plugin is not compatible with Gradle 6.x. Picking that version would force every consumer of Kordamp to upgrade to Gradle 7.x immediately.

@musketyr
Copy link
Contributor

@musketyr musketyr commented on 28bac60 Jul 13, 2021 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.