Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support allocating from reservation when no resource matched #2279

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

scheduler:

  • Support a pod with no matched resource to allocate reserved resources when it specifies a reservation affinity.
  • Improve logs of the topology-aware scheduling for diagnosis.

Ⅱ. Does this pull request fix one issue?

It helps when a pod want to bind to a reservation even if it does not request any reserved resource.

e.g. A Batch pod can allocate to a reservation if there are sufficient resources from the node, even when batch resources are not reserved.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the scheduler-reservation-allocatable-to-request-zero-pods branch from 5833ee6 to f2c4c1c Compare November 25, 2024 04:06
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.05%. Comparing base (0f574d2) to head (f2c4c1c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../scheduler/frameworkext/topologymanager/manager.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2279   +/-   ##
=======================================
  Coverage   66.04%   66.05%           
=======================================
  Files         454      454           
  Lines       53406    53405    -1     
=======================================
+ Hits        35274    35276    +2     
+ Misses      15593    15591    -2     
+ Partials     2539     2538    -1     
Flag Coverage Δ
unittests 66.05% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Contributor

/approve

@koordinator-bot koordinator-bot bot merged commit ceff9cd into koordinator-sh:main Nov 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants