koordlet: collect metric for host application memory usage with page cache #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
- Coverage 66.04% 66.03% -0.01%
==========================================
Files 454 454
Lines 53491 53514 +23
==========================================
+ Hits 35326 35339 +13
- Misses 15621 15629 +8
- Partials 2544 2546 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
2 times, most recently
from
93054ce to
9b9d082
Compare
|
consider memoryCollectPolicy |
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
4 times, most recently
from
71a87b9 to
ba1c6d8
Compare
|
convert to ready after #2278 merged |
3 tasks
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
from
ba1c6d8 to
419f0b5
Compare
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
from
419f0b5 to
f908018
Compare
j4ckstraw
changed the title
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
from
f908018 to
7bb2f82
Compare
@saintube PTAL, thx |
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
from
7bb2f82 to
29889f5
Compare
saintube
reviewed
Dec 4, 2024
pkg/koordlet/metricsadvisor/collectors/hostapplication/host_app_collector.go
Outdated
Show resolved
Hide resolved
Signed-off-by: j4ckstraw <[email protected]>
Signed-off-by: j4ckstraw <[email protected]>
Signed-off-by: j4ckstraw <[email protected]>
j4ckstraw
force-pushed
the
record-host-application-memory-usage-with-page-cache
branch
from
fc8aac6 to
75ea274
Compare
|
/lgtm |
saintube
approved these changes
Dec 18, 2024
j4ckstraw
deleted the
record-host-application-memory-usage-with-page-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
collect host application memory usage with page cache.
rely on #2278
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test