Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: support strict gpu share with hami #2272

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Support GPU Share With HAMi

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (44b57d8) to head (39d7596).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...oordlet/runtimehooks/protocol/container_context.go 0.00% 7 Missing and 1 partial ⚠️
pkg/koordlet/runtimehooks/hooks/gpu/gpu.go 81.25% 4 Missing and 2 partials ⚠️
pkg/koordlet/util/system/config.go 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2272      +/-   ##
==========================================
- Coverage   66.03%   66.01%   -0.02%     
==========================================
  Files         458      458              
  Lines       53768    53834      +66     
==========================================
+ Hits        35507    35540      +33     
- Misses      15710    15739      +29     
- Partials     2551     2555       +4     
Flag Coverage Δ
unittests 66.01% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng ZiMengSheng force-pushed the gpu_share branch 2 times, most recently from 01cc653 to ebe1cbc Compare December 2, 2024 03:51
@ZiMengSheng ZiMengSheng force-pushed the gpu_share branch 3 times, most recently from 1641a7e to ceb949f Compare December 19, 2024 04:16
@ZiMengSheng ZiMengSheng force-pushed the gpu_share branch 3 times, most recently from be03800 to 159198a Compare December 19, 2024 07:55
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube added the lgtm label Dec 19, 2024
@koordinator-bot koordinator-bot bot merged commit a62dd49 into koordinator-sh:main Dec 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants