koord-descheduler: fix object limiter by move it to reconciler #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
+ Coverage 68.65% 68.66% +0.01%
==========================================
Files 430 430
Lines 40056 40078 +22
==========================================
+ Hits 27499 27520 +21
+ Misses 10192 10188 -4
- Partials 2365 2370 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
songtao98
force-pushed
the
fix_object_limiter_arbitration_bug
branch
3 times, most recently
from
42c21e9 to
513a270
Compare
songtao98
changed the title
songtao98
force-pushed
the
fix_object_limiter_arbitration_bug
branch
from
513a270 to
96f7d53
Compare
songtao98
force-pushed
the
fix_object_limiter_arbitration_bug
branch
4 times, most recently
from
2f80906 to
b7414ba
Compare
songtao98
force-pushed
the
fix_object_limiter_arbitration_bug
branch
2 times, most recently
from
9e98f5c to
bc45a0b
Compare
Signed-off-by: songtao98 <[email protected]>
songtao98
force-pushed
the
fix_object_limiter_arbitration_bug
branch
from
bc45a0b to
7fa537d
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
The arbitrator relies on golang's
rate.Limiterpackage to implement workload-level eviction limter. However, only when theMigrationControllerevicts a pod successfully, the limiter's tokens will be consumed. That leads to a high possibility that the number ofPodMigrationJobpasses the arbitration is more than objectLimiter's upper bound, so that we cannot really limit the number of pods being evicted inside a timewindow.This PR moves the objectlimiter from arbitrator to reconciler. Thus it can be checked based on the real number.
Ⅱ. Does this pull request fix one issue?
fixes #2074
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test