-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add taskids in statesinformer #2057
koordlet: add taskids in statesinformer #2057
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
+ Coverage 68.56% 68.67% +0.10%
==========================================
Files 430 430
Lines 39383 40180 +797
==========================================
+ Hits 27004 27594 +590
- Misses 10043 10217 +174
- Partials 2336 2369 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@saintube PTAL. |
2ef1f0b
to
0107ae9
Compare
@saintube PTAL. |
Signed-off-by: Zhang Kang <[email protected]>
c51f882
to
14e3fab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add taskids for each pod as an attributes. It's part of the #1974. Resctrl runtime hook will leverage this to write new taskids to resctrl group.
Ⅱ. Does this pull request fix one issue?
#1831
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test