Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add resctrl updater #2052

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

Add new schemata updater for resctrl runtime hook. It's part of the #1974. Resctrl runtime hook will leverage this to create the resctrl group and write schemata.

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 68.64%. Comparing base (eed98fa) to head (a1a9529).
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/koordlet/util/system/resctrl.go 11.76% 13 Missing and 2 partials ⚠️
pkg/koordlet/resourceexecutor/resctrl_updater.go 82.75% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
+ Coverage   68.56%   68.64%   +0.07%     
==========================================
  Files         430      430              
  Lines       39383    39615     +232     
==========================================
+ Hits        27004    27193     +189     
- Misses      10043    10073      +30     
- Partials     2336     2349      +13     
Flag Coverage Δ
unittests 68.64% <66.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kangclzjc kangclzjc force-pushed the dev_updater branch 4 times, most recently from 93d73cb to ac7ae40 Compare May 21, 2024 09:34
@kangclzjc
Copy link
Member Author

@saintube PTAL.

Signed-off-by: Zhang Kang <[email protected]>
Signed-off-by: Zhang Kang <[email protected]>
@kangclzjc kangclzjc requested a review from saintube May 31, 2024 01:22
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 60d7b55 into koordinator-sh:main Jun 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants