-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support cri-o container runtime #1983
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 68.77% 68.71% -0.07%
==========================================
Files 422 423 +1
Lines 39058 39137 +79
==========================================
+ Hits 26864 26893 +29
- Misses 9870 9914 +44
- Partials 2324 2330 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@georgexiang Please make the commit signed off to pass the DCO check. |
f95d1c0
to
13d6dcf
Compare
@saintube Thanks for the reminder. Have followed the instruction. make the commit signed off, and passed DCO check. |
Hi @saintube , help me look at , at this stage , how to chang this PR commit , to pass " |
Please check the indention of your code. The linter check shows you can correct the code via the command |
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: ocichina001 <[email protected]> Signed-off-by: george <[email protected]>
… annotation (koordinator-sh#1982) Signed-off-by: sjtufl <[email protected]> Signed-off-by: george <[email protected]>
…nator-sh#1999) Signed-off-by: wangjianyu.wjy <[email protected]> Co-authored-by: wangjianyu.wjy <[email protected]> Signed-off-by: george <[email protected]>
…ator-sh#1994) Signed-off-by: wangjianyu.wjy <[email protected]> Co-authored-by: wangjianyu.wjy <[email protected]> Signed-off-by: george <[email protected]>
Signed-off-by: george <[email protected]>
767821e
to
f3b35a8
Compare
Thanks for your suggestion. Have gofmted related files, passed the gofmt check. |
Signed-off-by: george <[email protected]>
… into cri-o-runtime Signed-off-by: george <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@hormes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
This PR will add koordlet support for the cri-o runtime , solve problems like "│ koordlet-vgmdg W0403 04:29:39.470690 919471 cgroup_reconcile.go:226] parse containerDir error! msg: unknown container protocol cri-o://088b531d2f86e63c6f35c823078 1be16fb0fe5788c14761812d1e8666596e0d
” running error.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Deploying koordinatr in the cri-o v1.28 environment runs normally.
Ⅳ. Special notes for reviews
V. Checklist
make test