Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add core sched apis #1720

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Oct 24, 2023

Ⅰ. Describe what this PR does

koordlet: add the apis for the Linux Core Scheduling feature.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f197bbc) 66.03% compared to head (952d4d9) 66.06%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
+ Coverage   66.03%   66.06%   +0.03%     
==========================================
  Files         388      388              
  Lines       42314    42349      +35     
==========================================
+ Hits        27940    27977      +37     
+ Misses      12303    12301       -2     
  Partials     2071     2071              
Flag Coverage Δ
unittests 66.06% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the koordlet-init-core-sched branch from f5fe089 to ebe1086 Compare October 25, 2023 09:21
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fillzpp, jasonliu747 after the PR has been reviewed.
You can assign the PR to them by writing /assign @fillzpp @jasonliu747 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saintube saintube force-pushed the koordlet-init-core-sched branch from ebe1086 to 3091e6a Compare October 25, 2023 09:36
@koordinator-bot koordinator-bot bot added size/L and removed size/XXL labels Oct 25, 2023
@saintube saintube changed the title [WIP] koordlet: add core sched apis and utils koordlet: add core sched apis Oct 25, 2023
apis/slo/v1alpha1/pod.go Outdated Show resolved Hide resolved
@saintube saintube force-pushed the koordlet-init-core-sched branch 2 times, most recently from b074490 to 9dc9f6c Compare October 26, 2023 04:28
apis/slo/v1alpha1/pod.go Outdated Show resolved Hide resolved
apis/slo/v1alpha1/nodeslo_types.go Outdated Show resolved Hide resolved
apis/slo/v1alpha1/pod.go Outdated Show resolved Hide resolved
@saintube saintube force-pushed the koordlet-init-core-sched branch 2 times, most recently from 3f05ae7 to 1fecf5c Compare November 8, 2023 02:15
@zwzhang0107 zwzhang0107 changed the title koordlet: add core sched apis apis: add core sched apis Nov 8, 2023
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra
Copy link
Member

eahydra commented Nov 9, 2023

/lgtm

@saintube saintube force-pushed the koordlet-init-core-sched branch from 1fecf5c to c21ade5 Compare November 10, 2023 08:15
@saintube saintube force-pushed the koordlet-init-core-sched branch from c21ade5 to eba5422 Compare November 10, 2023 08:33
@saintube saintube force-pushed the koordlet-init-core-sched branch from eba5422 to 952d4d9 Compare November 13, 2023 02:52
@hormes
Copy link
Member

hormes commented Nov 13, 2023

/approve

@koordinator-bot koordinator-bot bot merged commit b6a7d9e into koordinator-sh:main Nov 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants