-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: cold memory fix usageWithHotPage and add usageWithPageCache #1699
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
==========================================
- Coverage 65.93% 65.92% -0.01%
==========================================
Files 384 385 +1
Lines 41474 41869 +395
==========================================
+ Hits 27344 27601 +257
- Misses 12106 12222 +116
- Partials 2024 2046 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pkg/koordlet/metricsadvisor/collectors/podresource/pod_resource_collector.go
Outdated
Show resolved
Hide resolved
pkg/koordlet/metricsadvisor/collectors/pagecache/page_cache_collector.go
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <[email protected]>
Signed-off-by: BUPT-wxq <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PTAL @zwzhang0107 @eahydra @hormes @ZiMengSheng @jasonliu747
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test