Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: cold memory fix usageWithHotPage and add usageWithPageCache #1699

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

BUPT-wxq
Copy link
Contributor

@BUPT-wxq BUPT-wxq commented Oct 9, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (d04f86b) 65.93% compared to head (71bfab7) 65.92%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   65.93%   65.92%   -0.01%     
==========================================
  Files         384      385       +1     
  Lines       41474    41869     +395     
==========================================
+ Hits        27344    27601     +257     
- Misses      12106    12222     +116     
- Partials     2024     2046      +22     
Flag Coverage Δ
unittests 65.92% <70.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/koordlet/metriccache/metric_types.go 58.13% <ø> (ø)
...llectors/coldmemoryresource/cold_page_collector.go 86.95% <100.00%> (+1.24%) ⬆️
.../collectors/coldmemoryresource/cold_page_kidled.go 60.35% <100.00%> (+0.23%) ⬆️
pkg/koordlet/metricsadvisor/framework/config.go 100.00% <100.00%> (ø)
pkg/koordlet/util/cold_page.go 100.00% <100.00%> (ø)
pkg/koordlet/util/meminfo.go 86.00% <100.00%> (+0.43%) ⬆️
pkg/koordlet/util/system/cgroup.go 76.19% <0.00%> (-1.59%) ⬇️
pkg/koordlet/util/system/kidled_util.go 80.86% <75.00%> (-2.77%) ⬇️
.../koordlet/statesinformer/impl/states_nodemetric.go 54.64% <55.55%> (-1.12%) ⬇️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/koordlet/util/system/cgroup.go Outdated Show resolved Hide resolved
pkg/koordlet/metriccache/metric_types.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/kidled_util.go Outdated Show resolved Hide resolved
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Oct 14, 2023
@BUPT-wxq BUPT-wxq changed the title [WIP] koordlet: cold memory fix usageWithHotPage and add usageWithPageCache koordlet: cold memory fix usageWithHotPage and add usageWithPageCache Oct 14, 2023
pkg/koordlet/metricsadvisor/framework/config.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/framework/config.go Outdated Show resolved Hide resolved
pkg/koordlet/resourceexecutor/reader.go Outdated Show resolved Hide resolved
pkg/koordlet/util/cold_page.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/kidled_util.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/kidled_util.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/kidled_util.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/kidled_util.go Outdated Show resolved Hide resolved
pkg/koordlet/statesinformer/impl/states_nodemetric.go Outdated Show resolved Hide resolved
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit cae8705 into koordinator-sh:main Oct 24, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants