-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile: support multiarch image build #1697
dockerfile: support multiarch image build #1697
Conversation
27c8ca4
to
b79fed9
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
- Coverage 65.93% 65.91% -0.02%
==========================================
Files 384 384
Lines 41474 41557 +83
==========================================
+ Hits 27344 27393 +49
- Misses 12106 12133 +27
- Partials 2024 2031 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b975556
to
671ff01
Compare
Signed-off-by: saintube <[email protected]>
671ff01
to
56184f7
Compare
/cc @zwzhang0107 @eahydra @hormes @jasonliu747 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
dockerfile: support mutli-arch image build.
sigs.k8s.io/controller-runtime/tools/setup-envtest
to resolve the Golang version issues in the latest version.Ⅱ. Does this pull request fix one issue?
fixes #1245.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test