-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: optimize reservation BeforePreFilter performance #1695
scheduler: optimize reservation BeforePreFilter performance #1695
Conversation
7b45c9b
to
d31b00d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
- Coverage 65.93% 65.92% -0.01%
==========================================
Files 384 384
Lines 41474 41557 +83
==========================================
+ Hits 27344 27396 +52
- Misses 12106 12136 +30
- Partials 2024 2025 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
d31b00d
to
518837b
Compare
Signed-off-by: Joseph <[email protected]>
518837b
to
b3d517b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nice optimization!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Optimize plugin Reservation's BeforePreFilter performance.
Ⅱ. Does this pull request fix one issue?
fix #1696
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test