Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: revise the validation of Pod resources #1693

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 29, 2023

Ⅰ. Describe what this PR does

Remove unused validation about Pod resources, add validation that required the cpu of LSR/LSE Pod must be specified and must be integer.

Ⅱ. Does this pull request fix one issue?

fix #1692

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra requested a review from hormes September 29, 2023 10:34
@koordinator-bot koordinator-bot bot requested a review from FillZpp September 29, 2023 10:34
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (125e52a) 65.99% compared to head (79c1f2b) 65.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
- Coverage   65.99%   65.94%   -0.06%     
==========================================
  Files         385      384       -1     
  Lines       41595    41474     -121     
==========================================
- Hits        27451    27349     -102     
+ Misses      12122    12099      -23     
- Partials     2022     2026       +4     
Flag Coverage Δ
unittests 65.94% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bhook/pod/validating/cluster_colocation_profile.go 89.02% <100.00%> (-1.98%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra
Copy link
Member Author

eahydra commented Sep 30, 2023

/hold

@eahydra
Copy link
Member Author

eahydra commented Sep 30, 2023

/hold cancel

@hormes
Copy link
Member

hormes commented Sep 30, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d04f86b into koordinator-sh:main Sep 30, 2023
18 checks passed
j4ckstraw pushed a commit to j4ckstraw/koordinator that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] failed to create Pod with sidecar container
2 participants