-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: revise the validation of Pod resources #1693
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
- Coverage 65.99% 65.94% -0.06%
==========================================
Files 385 384 -1
Lines 41595 41474 -121
==========================================
- Hits 27451 27349 -102
+ Misses 12122 12099 -23
- Partials 2022 2026 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/hold |
Signed-off-by: Joseph <[email protected]>
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Joseph <[email protected]>
Ⅰ. Describe what this PR does
Remove unused validation about Pod resources, add validation that required the cpu of LSR/LSE Pod must be specified and must be integer.
Ⅱ. Does this pull request fix one issue?
fix #1692
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test