Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: optimize elastic quota log #1690

Merged

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (ad0e1e4) 66.02% compared to head (a463781) 65.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
- Coverage   66.02%   65.94%   -0.08%     
==========================================
  Files         385      385              
  Lines       41589    41595       +6     
==========================================
- Hits        27459    27430      -29     
- Misses      12112    12135      +23     
- Partials     2018     2030      +12     
Flag Coverage Δ
unittests 65.94% <32.46%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/scheduler/plugins/elasticquota/controller.go 48.95% <100.00%> (ø)
...duler/plugins/elasticquota/quota_overuse_revoke.go 71.83% <90.00%> (+0.16%) ⬆️
...kg/scheduler/plugins/elasticquota/quota_handler.go 76.76% <63.63%> (ø)
pkg/scheduler/plugins/elasticquota/pod_handler.go 60.00% <50.00%> (+0.74%) ⬆️
...gins/elasticquota/core/runtime_quota_calculator.go 86.20% <0.00%> (-0.12%) ⬇️
...ticquota/core/scale_minquota_when_over_root_res.go 88.63% <0.00%> (-11.37%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 74.24% <7.69%> (-1.39%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra changed the title fix elastic quota log koord-scheduler: optimize elastic quota log Sep 29, 2023
@shaloulcy shaloulcy force-pushed the fix_elastic_quota_log branch from 5fc32c4 to 1827fdb Compare September 29, 2023 09:03
Signed-off-by: chuanyun.lcy <[email protected]>
@shaloulcy shaloulcy force-pushed the fix_elastic_quota_log branch from 1827fdb to a463781 Compare September 29, 2023 09:08
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 125e52a into koordinator-sh:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants