Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: add decorator for quota #1686

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: chuanyun.lcy <[email protected]>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f530ded) 66.12% compared to head (fd914a6) 65.99%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   66.12%   65.99%   -0.13%     
==========================================
  Files         384      385       +1     
  Lines       41524    41589      +65     
==========================================
- Hits        27458    27448      -10     
- Misses      12044    12119      +75     
  Partials     2022     2022              
Flag Coverage Δ
unittests 65.99% <90.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/quota-controller/profile/profile_controller.go 68.48% <100.00%> (+1.81%) ⬆️
...kg/scheduler/plugins/elasticquota/quota_handler.go 76.76% <100.00%> (+0.23%) ⬆️
pkg/scheduler/plugins/elasticquota/controller.go 48.95% <72.72%> (+1.98%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Sep 26, 2023
@@ -101,6 +110,14 @@ func (ctrl *Controller) syncHandler() []error {
return
}

// decorate resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why all the fileds should be decorated? Please add some comments to help reading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: chuanyun.lcy <[email protected]>
@eahydra
Copy link
Member

eahydra commented Sep 28, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ad0e1e4 into koordinator-sh:main Sep 29, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants