-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: add decorator for quota #1686
koord-scheduler: add decorator for quota #1686
Conversation
Signed-off-by: chuanyun.lcy <[email protected]>
2b6ed93
to
bbc1fbd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
- Coverage 66.12% 65.99% -0.13%
==========================================
Files 384 385 +1
Lines 41524 41589 +65
==========================================
- Hits 27458 27448 -10
- Misses 12044 12119 +75
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -101,6 +110,14 @@ func (ctrl *Controller) syncHandler() []error { | |||
return | |||
} | |||
|
|||
// decorate resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why all the fileds should be decorated? Please add some comments to help reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: chuanyun.lcy <[email protected]>
53b948f
to
fd914a6
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test