-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: NodeNUMAResource scoring fix and tweak with node-level amplification ratios #1683
koord-scheduler: NodeNUMAResource scoring fix and tweak with node-level amplification ratios #1683
Conversation
607c07d
to
6b2d924
Compare
/cc @eahydra |
Signed-off-by: Zach Zhu <[email protected]>
Signed-off-by: Zach Zhu <[email protected]>
…equest Signed-off-by: Zach Zhu <[email protected]>
6b2d924
to
6a20b87
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
- Coverage 66.12% 66.11% -0.01%
==========================================
Files 384 384
Lines 41528 41524 -4
==========================================
- Hits 27460 27454 -6
+ Misses 12052 12050 -2
- Partials 2016 2020 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
This is the following-up PR of #1677 fixing its dangling comments. It also does some unification to the node resource amplification apis.
Ⅱ. Does this pull request fix one issue?
part of #1539
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test