Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: NodeNUMAResource scoring fix and tweak with node-level amplification ratios #1683

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

zqzten
Copy link
Member

@zqzten zqzten commented Sep 24, 2023

Ⅰ. Describe what this PR does

This is the following-up PR of #1677 fixing its dangling comments. It also does some unification to the node resource amplification apis.

Ⅱ. Does this pull request fix one issue?

part of #1539

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zqzten
Copy link
Member Author

zqzten commented Sep 24, 2023

/cc @eahydra

@koordinator-bot koordinator-bot bot requested a review from eahydra September 24, 2023 15:17
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01% ⚠️

Comparison is base (fc26933) 66.12% compared to head (6a20b87) 66.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
- Coverage   66.12%   66.11%   -0.01%     
==========================================
  Files         384      384              
  Lines       41528    41524       -4     
==========================================
- Hits        27460    27454       -6     
+ Misses      12052    12050       -2     
- Partials     2016     2020       +4     
Flag Coverage Δ
unittests 66.11% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 68.43% <50.00%> (-0.09%) ⬇️
...r/plugins/loadaware/estimator/default_estimator.go 89.55% <100.00%> (ø)
pkg/scheduler/plugins/nodenumaresource/scoring.go 75.15% <100.00%> (-0.46%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f530ded into koordinator-sh:main Sep 25, 2023
@zqzten zqzten deleted the scheduler_amp_fix branch September 25, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants