koord-scheduler: add e2e case for multi quota tree #1675
Conversation
shaloulcy
force-pushed
the
add_e2e_for_quota
branch
from
bdc5619 to
9aba811
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1675 +/- ##
==========================================
+ Coverage 65.94% 66.08% +0.13%
==========================================
Files 380 384 +4
Lines 40960 41454 +494
==========================================
+ Hits 27013 27393 +380
- Misses 11970 12045 +75
- Partials 1977 2016 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
test/e2e/quota/multi_tree.go
Outdated
| }) | ||
| }) | ||
|
|
||
| func MarshalValue(val interface{}) string { |
There was a problem hiding this comment.
duplicate with pkg/util/json.go DumpJSON
test/e2e/quota/multi_tree.go
Outdated
| return false | ||
| }, 60*time.Second, 1*time.Second).Should(gomega.Equal(true)) | ||
|
|
||
| ginkgo.By("create quota profile2 with resource ratio") |
There was a problem hiding this comment.
There seem to be two scenarios, but they are both written together. It is recommended to split them into different cases.
shaloulcy
force-pushed
the
add_e2e_for_quota
branch
3 times, most recently
from
1882943 to
7d12c32
Compare
Signed-off-by: chuanyun.lcy <[email protected]>
shaloulcy
force-pushed
the
add_e2e_for_quota
branch
from
7d12c32 to
bf6ee05
Compare
saintube
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test