Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: Add non-preemptible feature in Elastic Quota Management #1668

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

tan90github
Copy link
Contributor

Ⅰ. Describe what this PR does

Add non-preemptible feature in Elastic Quota Management

Ⅱ. Does this pull request fix one issue?

fixes #1473

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (14087cb) 65.91% compared to head (6750752) 65.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   65.91%   65.90%   -0.01%     
==========================================
  Files         384      384              
  Lines       41568    41613      +45     
==========================================
+ Hits        27398    27426      +28     
- Misses      12137    12152      +15     
- Partials     2033     2035       +2     
Flag Coverage Δ
unittests 65.90% <70.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...heduler/plugins/elasticquota/core/quota_summary.go 0.00% <ø> (ø)
...kg/scheduler/plugins/elasticquota/plugin_helper.go 72.33% <100.00%> (+0.13%) ⬆️
...duler/plugins/elasticquota/quota_overuse_revoke.go 71.02% <0.00%> (-0.82%) ⬇️
pkg/scheduler/plugins/elasticquota/preempt.go 1.88% <0.00%> (-0.04%) ⬇️
pkg/webhook/elasticquota/pod_check.go 53.24% <0.00%> (-2.16%) ⬇️
.../scheduler/plugins/elasticquota/core/quota_info.go 82.48% <87.87%> (-0.63%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 57.60% <71.42%> (+1.77%) ⬆️
...r/plugins/elasticquota/core/group_quota_manager.go 73.90% <65.21%> (-0.35%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra requested review from hormes and shaloulcy September 19, 2023 01:37
@eahydra eahydra changed the title Add non-preemptible feature in Elastic Quota Management koord-scheduler: Add non-preemptible feature in Elastic Quota Management Sep 19, 2023
apis/extension/elastic_quota.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
@tan90github tan90github force-pushed the feat-non-preempt-dev branch 3 times, most recently from 01ec84e to b5aa886 Compare September 25, 2023 03:08
@tan90github tan90github requested a review from eahydra September 25, 2023 03:26
@hormes
Copy link
Member

hormes commented Sep 26, 2023

After the non-preemptible Pod reaches min, should it be rejected now or should it remain pending?

@shaloulcy
Copy link
Contributor

After the non-preemptible Pod reaches min, should it be rejected now or should it remain pending?

pending

@tan90github
Copy link
Contributor Author

After the non-preemptible Pod reaches min, should it be rejected now or should it remain pending?

now it will pending

@tan90github tan90github force-pushed the feat-non-preempt-dev branch from b5aa886 to 0ad5044 Compare October 8, 2023 07:45
@tan90github tan90github requested a review from shaloulcy October 8, 2023 08:07
@shaloulcy
Copy link
Contributor

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot koordinator-bot bot removed the lgtm label Oct 10, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5941c67 into koordinator-sh:main Oct 10, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Add non-preemptible feature in Elastic Quota Management
4 participants