-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: Add non-preemptible feature in Elastic Quota Management #1668
koord-scheduler: Add non-preemptible feature in Elastic Quota Management #1668
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
- Coverage 65.91% 65.90% -0.01%
==========================================
Files 384 384
Lines 41568 41613 +45
==========================================
+ Hits 27398 27426 +28
- Misses 12137 12152 +15
- Partials 2033 2035 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
f944c86
to
e051603
Compare
01ec84e
to
b5aa886
Compare
After the non-preemptible Pod reaches min, should it be rejected now or should it remain pending? |
pending |
now it will pending |
b5aa886
to
0ad5044
Compare
/lgtm |
0ad5044
to
82dbb62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Signed-off-by: wangyang55 <[email protected]>
Signed-off-by: wangyang55 <[email protected]>
Signed-off-by: wangyang55 <[email protected]>
Signed-off-by: wangyang55 <[email protected]>
82dbb62
to
6750752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5941c67
into
koordinator-sh:main
Ⅰ. Describe what this PR does
Add non-preemptible feature in Elastic Quota Management
Ⅱ. Does this pull request fix one issue?
fixes #1473
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test