koord-descheduler: add arbitration to migration controller #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: baowj <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 65.82% 66.01% +0.19%
==========================================
Files 375 385 +10
Lines 39549 41569 +2020
==========================================
+ Hits 26032 27442 +1410
- Misses 11630 12109 +479
- Partials 1887 2018 +131
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eahydra
reviewed
Sep 17, 2023
1.update klog to return; 2.always enable arbitration; Signed-off-by: baowj <[email protected]>
1.move codes from `migration/filter.go` to `migration/arbitrator/filter.go` Signed-off-by: baowj <[email protected]>
1.remove AnnotationPassedArbitration's deletion. Signed-off-by: baowj <[email protected]>
eahydra
reviewed
Sep 22, 2023
|
@ZiMengSheng PTAL |
1.remove lock in migration Reconciler; 2.move codes from migration/filter.go to migration/controller.go; 3.remove some comments; 4.remove explicit initialization of mu in arbitration/filter.go; Signed-off-by: baowj <[email protected]>
1.make filter a member variable of arbitrator; Signed-off-by: baowj-678 <[email protected]>
eahydra
reviewed
Sep 23, 2023
1.add passed arbitration PodMigrationJob record map. Signed-off-by: baowj-678 <[email protected]>
eahydra
reviewed
Sep 25, 2023
1.move eventHandler to a single file; 2.rename Add & Delete; 3.use local record PassedArbitration status only; 4.add nonRetryablePodFilter/retryablePodFilter to Filter func. Signed-off-by: baowj <[email protected]>
eahydra
reviewed
Sep 25, 2023
1.add pod arbitrating annotation; 2.rename arbitrationHandler variables; 3.update comments; Signed-off-by: baowj <[email protected]>
eahydra
reviewed
Sep 25, 2023
1.update PhaseAndAnnotation to expectedPhaseContext; 2.convert Object to PMJ instead using client to get; Signed-off-by: baowj <[email protected]>
1.rename some variables and structure; Signed-off-by: baowj <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
j4ckstraw
pushed a commit
to j4ckstraw/koordinator
that referenced
this pull request
May 20, 2024
…or-sh#1651) Signed-off-by: baowj <[email protected]> Signed-off-by: baowj-678 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Add the arbitration to migration controller according to #1454.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test