Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: CPU Normalization #1598

Merged

Conversation

zqzten
Copy link
Member

@zqzten zqzten commented Aug 31, 2023

This is the proposal of #1570.

@zqzten
Copy link
Member Author

zqzten commented Aug 31, 2023

/cc @saintube @eahydra @zwzhang0107

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14087cb) 65.91% compared to head (e4e1f05) 65.90%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   65.91%   65.90%   -0.01%     
==========================================
  Files         384      384              
  Lines       41568    41568              
==========================================
- Hits        27398    27395       -3     
- Misses      12137    12141       +4     
+ Partials     2033     2032       -1     
Flag Coverage Δ
unittests 65.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Sep 2, 2023

/lgtm

@zqzten
Copy link
Member Author

zqzten commented Sep 3, 2023

/hold until we make final confirmation of the impl detail of koord-manager and koord-scheduler.

@zqzten zqzten force-pushed the cpu-normalization-proposal branch from 6b17cc4 to e4e1f05 Compare October 10, 2023 03:16
@koordinator-bot koordinator-bot bot removed the lgtm label Oct 10, 2023
@zqzten
Copy link
Member Author

zqzten commented Oct 10, 2023

Update: Move the scheduler part to #1700 and update some impl details with the latest actual impls.

/unhold
PTAL @hormes

@eahydra
Copy link
Member

eahydra commented Nov 23, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9f9557e into koordinator-sh:main Nov 23, 2023
20 of 21 checks passed
@zqzten zqzten deleted the cpu-normalization-proposal branch November 23, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants