Skip to content

Commit

Permalink
chore: improve pull request template (#277)
Browse files Browse the repository at this point in the history
Signed-off-by: Jason Liu <[email protected]>
  • Loading branch information
jasonliu747 authored Jun 22, 2022
1 parent 46fd995 commit 7dcd1ee
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 13 deletions.
12 changes: 0 additions & 12 deletions .github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

22 changes: 22 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
### Ⅰ. Describe what this PR does

<!--
- Summarize your change (**mandatory**)
- How does this PR work? Need a brief introduction for the changed logic (optional)
- Describe clearly one logical change and avoid lazy messages (optional)
- Describe any limitations of the current code (optional)
-->

### Ⅱ. Does this pull request fix one issue?

<!--If so, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

### Ⅲ. Describe how to verify it

### Ⅳ. Special notes for reviews

### V. Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in `make test`
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Make any change on the new-branch then build and test your codes.

PR is the only way to make change to Koordinator project files. To help reviewers better get your purpose, PR
description could not be too detailed. We encourage contributors to follow
the [PR template](./.github/PULL_REQUEST_TEMPLATE.md) to finish the pull request.
the [PR template](./.github/pull_request_template.md) to finish the pull request.

### Developing Environment

Expand Down

0 comments on commit 7dcd1ee

Please sign in to comment.