🐛 Update archetype model, form and detail drawer to current hub spec #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changes:
- Update `models.ts` to the current state of `TagRef` and `Archetype`
in terms of field names and data types.
- Update `ArchetypeForm` to use `criteria` instead of `criteriaTags`
as per the api model changes.
- The tags column on the archetype table is currently displaying ALL
tags returned with no source differentiation.
- MSW stub data updated to use api model changes.
- Drop a `console.log` from `Autocomplete`
Todo:
- Check `Archetype.tags` contents so virtual / assessment tags are
not editable in the `ArchetypeForm`. This should be similar behavior
as the Application edit form. Only the "manual" tags should be
editable.
- Check archetype detail drawer so the "manual" tags and the tags
from other sources are displayed properly. The application detail
drawer shows manual, assessment and analysis tags.
- The assessment wizard is also broken for application and archetype
assessments.
Signed-off-by: Scott J Dickerson <[email protected]>
Since all tags for an archetype are provided in the same field `tags`, filter them into "archetype tags" (i.e. an empty source) and "assessment tags" (i.e. have a non-empty source) to display them separately. Note: The "archetype tags" are the tags manually attached to the archetype in the new/edit form. Signed-off-by: Scott J Dickerson <[email protected]>
With hub changes to combine the archetype and non-archetype tags into a single field, change the form processing such that the non-archetype fields are ignored but still sent on an update. This change mirrors the behavior of manual / non-manual tags on applications and the application form. Stakeholder and stakeholder groups handling is updated to use the `*ToRef()` helper function style introduced in the application form change konveyor#1408. Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
archetype_model_change
branch
from
2b4aeed to
26b5123
Compare
ibolton336
requested changes
Oct 5, 2023
|
|
||
| const assessmentTags = | ||
| archetype?.tags | ||
| ?.filter((t) => t?.source ?? "" !== "") |
There was a problem hiding this comment.
Are we looking to filter by assessment source here?
There was a problem hiding this comment.
Like the filters in the tags tab of the application drawer? ... No. That is not in the enhancement doc.
There was a problem hiding this comment.
Ok. It just wasn't clear to me exactly what the empty source was meaning in this context.
There was a problem hiding this comment.
I was looking for the actual "assessment" source type like we see here
With this logic, it looks like the assessment tags are going to be categorized as archetype tags && assessment tags.
There was a problem hiding this comment.
Yeah... once I can run an assessment on an archetype I'll be able to verify that's what it would look like.
There was a problem hiding this comment.
The logic is...
- if the tag source is undefined or empty, it is an archetype tag
- if the tag source is not empty, it is an assessment tag
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
=======================================
Coverage 41.07% 41.08%
=======================================
Files 139 139
Lines 4404 4403 -1
Branches 1010 1010
=======================================
Hits 1809 1809
+ Misses 2583 2582 -1
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Oct 6, 2023
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Oct 6, 2023
Follow up: konveyor#1438 Api changed and if a tag's source is empty, the field is not sent. Change the tag filtering test to consider `source === undefined` and `source === ""` as manual tags. Signed-off-by: Scott J Dickerson <[email protected]>
ibolton336
added a commit
that referenced
this pull request
Oct 9, 2023
Follow up: #1438 Api changed and if a tag's source is empty, the field is not sent. Change the tag filtering test to consider `source === undefined` and `source === ""` as manual tags. Signed-off-by: Scott J Dickerson <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #1436
With hub updates to tag handling and api field name changes related to archetypes, adjustments needed to be made to the UI.
Archetype model
Update
models.tsto the current state ofTagRefandArchetypein terms of field names and data types.MSW stub data updated to use api model changes.
Archetype Table
Archetype Add/EditForm
Update
ArchetypeFormto usecriteriainstead ofcriteriaTagsas per the api model changes.With hub changes to combine the archetype and non-archetype tags into a single field, the form processing now ignored non-archetype fields but still sends them on an update.
Note: This change mirrors the behavior of manual / non-manual tags on applications and the application form.
Stakeholder and stakeholder groups handling is updated to use the
*ToRef()helper function style introduced in the application form change 🐛 Applications form: Fix contributors and tags field handling #1408.Archetype Detail Drawer
Since all tags for an archetype are provided in the same field
tags, filter them into "archetype tags" (i.e. an empty source) and "assessment tags" (i.e. have a non-empty source) to display them separately.Note: The "archetype tags" are the tags manually attached to the archetype in the new/edit form.