-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add task dashboard report. #720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
jortel
force-pushed
the
propagate-task-error
branch
from
July 16, 2024 12:36
ce3d7db
to
cee22b4
Compare
jortel
commented
Jul 16, 2024
@@ -181,6 +183,7 @@ func (h TaskHandler) List(ctx *gin.Context) { | |||
db := h.DB(ctx) | |||
db = db.Model(&model.Task{}) | |||
db = db.Joins("Application") | |||
db = db.Joins("Report") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hint: joining so that /tasks will return the same resources as /tasks/:d.
mansam
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sjd78
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Jul 16, 2024
…ion tables (#2011) ### Summary Resolves: #1997 When a task is succeeded but has attached errors, render task state, application tasks state and application analysis state with a warning. ### Details of Changes With this change, hub is not adding a new terminal state, but having a new terminal state is an easy way to handle things. The task queries will now evaluate the `state` and `errors` props to determine if "Succeeded" should be "SucceededWithErrors". This synthetic task status makes updating all of the UI component much simpler. To function properly, HUB [Issue 725](konveyor/tackle2-hub#725) / [PR 720](konveyor/tackle2-hub#720) are required. Changes have also been made to utilize the `/tasks/reports/dashboard` endpoint to get a much smaller view of tasks when dealing with them in aggregate. The application details drawer was refactored to push data fetching closer to actual use, and to break up a very large component into a container component with a component dedicated to each tab. ### Screenshots Application inventory page: ![screenshot-localhost_9000-2024 07 15-18_33_20](https://github.com/user-attachments/assets/b7015ebf-4305-4d6d-a670-5e4fe532981d) Application tasks popover: ![image](https://github.com/user-attachments/assets/14d4d19e-eaca-4505-88be-d5016da1e70b) Task Manager page: ![screenshot-localhost_9000-2024 07 15-18_35_15](https://github.com/user-attachments/assets/2547a46a-1fa6-456f-836c-4e59cc0fd074) --------- Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better support succeeded with errors.
closes #725
needed by: konveyor/tackle2-ui#1997
Example:
GET /tasks/report/dashboard