Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add api_hub_tests_ref to CI on PRs #559

Merged
merged 2 commits into from
Nov 29, 2023
+1 −0
Merged

🌱 Add api_hub_tests_ref to CI on PRs #559

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0520fec
Add api_tests_ref to CI on PRs
aufi Nov 15, 2023
f0612e7
Update to head_ref
aufi Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,4 @@ jobs:
uses: konveyor/ci/.github/workflows/global-ci.yml@main
with:
component_name: tackle2-hub
api_hub_tests_ref: ${{ github.head_ref }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want github.ref_name here instead, I think head_ref will reference just the PR branch while ref_name will reference the merged PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow should affect only PRs. Once the change is merged the branch name (main and e.g. release-0.3) should be driven by already existing API_TESTS_REF.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the difference is head_ref targets /refs/pull/<PR #>/head whereas ref_name targets /refs/pull/<PR #>/merge. Generally we want to test with merge so that we get the results of the tests if that PR merged. Can help catch issues that are introduced on the main branch after a PR is introduced. Let me know if I'm missing something or talking past you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point, I misuderstood it before, thanks! I will update.

Loading